Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] Add environment variable to allow disable of sitemap fetch in getStaticPaths #1149

Merged
merged 4 commits into from
Sep 9, 2022
Merged

[Next.js] Add environment variable to allow disable of sitemap fetch in getStaticPaths #1149

merged 4 commits into from
Sep 9, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 8, 2022 •
edited
Loading

Description / Motivation

  • Disable pages pre-render based on environment variable DISABLE_SSG_FETCH value

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 8, 2022 10:23
ambrauer
ambrauer suggested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with DISABLE_SSG_FETCH. Related work has already started using this name and these need to be in sync.

ambrauer
ambrauer approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ambrauer ambrauer merged commit cc6a587 into dev Sep 9, 2022
@ambrauer ambrauer deleted the feature/545165 branch September 9, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer