Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NextJs] Specify AppProps generic type in _app.tsx to align with latest changes from Next 12.3.0 #1154

Merged
merged 3 commits into from
Sep 15, 2022
Merged

[NextJs] Specify AppProps generic type in _app.tsx to align with latest changes from Next 12.3.0 #1154

merged 3 commits into from
Sep 15, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 13, 2022 •
edited
Loading

Description / Motivation

  • Next 12.3.0 provides change to AppPages type, which requires to provide type for generic

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 13, 2022 13:14
ambrauer
ambrauer approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ambrauer ambrauer merged commit dc9e323 into dev Sep 15, 2022
@ambrauer ambrauer deleted the feature/551892 branch September 15, 2022 16:21
@illiakovalenko illiakovalenko mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer