Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure headers from middleare are passed into NativeFetcher #1177

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

art-alexeyenko
Copy link
Contributor

Fixing the issue when user-agent was ignored in fetcher when executing CDP experience.

Testing Details

To be further tested on Vercel or with mock.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team September 29, 2022 22:10
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ambrauer ambrauer merged commit 1ba7b99 into dev Sep 30, 2022
@ambrauer ambrauer deleted the bug/554403-ua-headers-not-passed branch September 30, 2022 13:58
ambrauer added a commit that referenced this pull request Oct 7, 2022
* Ensure headers from middleare are passed into NativeFetcher

* remove headers field on NativeFetcherOptions to avoid duplicates

(cherry picked from commit 1ba7b99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants