Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Improve unit test coverage reporting #1202

Merged
merged 18 commits into from
Oct 19, 2022
Merged

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 14, 2022

Description / Motivation

Introduce Cobertura - code coverage reporter which compatible with many testing libraries and with azure pipelines.

  • reportgenerator extension is installed to generate a fancy and user friendly html report
  • PublishCodeCoverageResults publish generated html report to azure pipelines

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [Innovate] Improve unit test coverage reporting [Maintenance] Improve unit test coverage reporting Oct 18, 2022
@illiakovalenko illiakovalenko requested a review from a team October 18, 2022 09:12
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with some comments. Would be nice to group the report by package as it is difficult to determine where source file originates, but this looks to be a limitation of Cobertura.

packages/sitecore-jss-angular/karma.conf.js Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit d0f8ebc into dev Oct 19, 2022
@illiakovalenko illiakovalenko deleted the feature/493879 branch October 19, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants