#557761: fixed sitemap handler #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavStativa
approved these changes
Nov 3, 2022
sc-ruslanmatkovskyi
force-pushed
the
bugfix/557761-sitemap
branch
from
a90a376 to
687d988
Compare
ambrauer
suggested changes
Nov 3, 2022
There was a problem hiding this comment.
See couple comments. In general, would also be good to see some comments to help a developer understand the logic in here. There is more going on now... See base nextjs initializers' api routes for examples.
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/api/sitemap.ts
Outdated
Show resolved
Hide resolved
ambrauer
added a commit
that referenced
this pull request
Dec 6, 2022
* #557761: fixed sitemap handler * #557761: refactoring and fixed comments (cherry picked from commit 16d2eeb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Testing Details
Types of changes