Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#559289: added implementation getEEMarkup into sitecore-jss-nextjs #1232

Merged
merged 2 commits into from
Nov 9, 2022
Merged

#559289: added implementation getEEMarkup into sitecore-jss-nextjs #1232

merged 2 commits into from
Nov 9, 2022

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ambrauer
ambrauer reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there no way to solve this (make it editor-friendly) without using getEEMarkup? As mentioned, this wasn't intended to be used externally... If this is the only way, then we can go with this.

@sc-ruslanmatkovskyi
Copy link
Collaborator Author

Was there no way to solve this (make it editor-friendly) without using getEEMarkup? As mentioned, this wasn't intended to be used externally... If this is the only way, then we can go with this.

Yeah! I removed this getEEMarkup and now there is using

ambrauer
ambrauer approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ambrauer ambrauer merged commit a9422d8 into dev Nov 9, 2022
@ambrauer ambrauer deleted the bugfix/559289 branch November 9, 2022 19:20
ambrauer added a commit that referenced this pull request Dec 6, 2022
@ambrauer
#559289: added implementation getEEMarkup into sitecore-jss-nextjs (#…
fe12678 
…1232)

* #559289: added implementation getEEMarkup into sitecore-jss-nextjs

* #559289: removed getEEMarkup implementation

(cherry picked from commit a9422d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-ruslanmatkovskyi @ambrauer