[nextjs][react]The language of the form is changed after clicking the submit button #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
reviewed
Dec 16, 2022
| form.metadata.itemId | ||
| }&fxb.HtmlPrefix=${form.htmlPrefix}&sc_apikey=${this.props.sitecoreApiKey}&sc_itemid=${ | ||
| form.contextItemId | ||
| }&sc_lang=${this.props.language || ''}`; |
There was a problem hiding this comment.
Should we exclude the query string parm completely if props.language is undefined? Not sure if there is any adverse side-effects with sending an empty value.
There was a problem hiding this comment.
I think that I tested and it was working when the value is an empty string, but for me it makes sense just to remove it
ambrauer
approved these changes
Dec 16, 2022
This was referenced Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Provides
languageproperty to usesc_langurl parameterTesting Details
Types of changes