Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][Multi-site] Better page props site resolution for editing/preview #1304

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[Next.js][Multi-site] Better page props site resolution for editing/preview #1304

merged 1 commit into from
Jan 26, 2023

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

  • Better page props site resolution for editing/preview
  • Added (missing) short-circuits for personalize and error-pages as well
  • Fixes issue where a newly added site fails to resolve in Pages (Pages appends sc_site query string to the canvas request under the hood)

Testing Details

Tested on XMC staging

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer
Better page props site resolution for editing/preview. Added (missing…
5e93cac 
…) short-circuits for personalize and error-pages as well.
@ambrauer ambrauer requested a review from a team January 25, 2023 20:38
illiakovalenko
illiakovalenko approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit e34b9f0 into dev Jan 26, 2023
@illiakovalenko illiakovalenko deleted the fix/570252 branch January 26, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambrauer @illiakovalenko