Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nextjs]Upgrade 3rd party dependencies #1305

Merged
merged 8 commits into from
Jan 27, 2023
Merged

[Nextjs]Upgrade 3rd party dependencies #1305

merged 8 commits into from
Jan 27, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 26, 2023

Description / Motivation

  • Upgraded 3rdy party libraries to latest versions except:
    • graphql and @graphql-codegen/cli@^2.0.0 - has graphql-tools -> @whatwg-node/fetch -> undici and imported files not resolved in the right way by webpack
      image
    • chalk@^5.0.0 can't be installed since it doesn't include cjs build anymore, but ^4.0.0 is fine to use (all features are the same)
    • sass-alias@^2.0.0 not compatible with nextjs sass webpack configuration
  • Now graphql-let generates types under node_modules/@types/graphql-let folder
  • Prettier typescript eslint rules are bundled into prettier extension
  • Enzyme react 18 warnings are suppressed since there is no new version for upgrade
  • Removed extra axios dependency and exposed AxiosResponse from sitecore-jss instead
  • Reimplemented tests for redirects_middleware, they didn't validate response and had been accepting invalid redirectType
  • Updated class names according to breaking changes provided by bootstrap 5

Testing Details

  • Manual testing
  • Ran yarn install, npm install

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team January 26, 2023 13:56
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one comment

@illiakovalenko illiakovalenko merged commit 99a88c9 into dev Jan 27, 2023
@illiakovalenko illiakovalenko deleted the feature/509110 branch January 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants