Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-sitecore-jss] Incompatibility message when installing sxa and styleguide #1315

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[create-sitecore-jss] Incompatibility message when installing sxa and styleguide #1315

merged 2 commits into from
Jan 31, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Adding incompatibility message when initializing nextjs sample app with both sxa with styleguide addons.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko
illiakovalenko requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just add Prompts handling as it works for Personalize add-on

illiakovalenko
illiakovalenko approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@illiakovalenko illiakovalenko changed the title Incompatibility message when installing sxa and styleguide [create-sitecore-jss] Incompatibility message when installing sxa and styleguide Jan 31, 2023
@illiakovalenko illiakovalenko merged commit 3b505d7 into dev Jan 31, 2023
@illiakovalenko illiakovalenko deleted the bug/sxa-styleguide-incompatible branch January 31, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko