Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Next 13 upgrade #1324

Merged
merged 6 commits into from
Feb 7, 2023
Merged

[Next.js] Next 13 upgrade #1324

merged 6 commits into from
Feb 7, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 3, 2023

Description / Motivation

  • Next is bumped to ^13.1.6
  • next/link component doesn't accept <a/> tag as a child anymore
  • next/image :
    • Component doesn't support layout property, fill (fluid image) needs to be used instead, which requires having relative positioned parent.
    • Set sizes value to be the same as we have for RAV.
    • Now alt is required property
  • next-transpile-modules not needed anymore, next now supports linked dependencies resolution OOTB, multiple react dependencies related fix also not required to be present anymore
  • Middleware's cookie.get now returns { value, name, ...rest } instead of value
  • Aligned unit tests according to new changes
  • Not related to upgrade:
    • Moved sitecore/manifest/sitecore-import.json fallback config from next-config/plugins/disconnected to next-config/plugins/styleguide, because error can be thrown in connected mode too

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@pzi
Copy link
Contributor

pzi commented Feb 6, 2023

Would upgrading a major dependency to it's next major version mean JSS-next has to go next major given there are some breaking changes coming with this?

@illiakovalenko illiakovalenko requested a review from a team February 6, 2023 06:53
@illiakovalenko
Copy link
Contributor Author

illiakovalenko commented Feb 6, 2023

@pzi You are right, the next released version will include breaking changes

Upd: CHANGELOG.md will be updated soon to reflect our latest version strategy

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! See a few suggestions/comments

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit f6f0f68 into dev Feb 7, 2023
@ambrauer ambrauer deleted the feature/559014 branch February 7, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants