-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next.js] Next 13 upgrade #1324
Conversation
Would upgrading a major dependency to it's next major version mean JSS-next has to go next major given there are some breaking changes coming with this? |
@pzi You are right, the next released version will include breaking changes Upd: CHANGELOG.md will be updated soon to reflect our latest version strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! See a few suggestions/comments
...reate-sitecore-jss/src/templates/nextjs-styleguide/src/lib/next-config/plugins/styleguide.js
Outdated
Show resolved
Hide resolved
...re-jss/src/templates/nextjs-styleguide/src/components/fields/Styleguide-FieldUsage-Image.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description / Motivation
<a/>
tag as a child anymoreTesting Details
Types of changes