Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nextjs] Sample in Docker env references linked packages using lowercase path #1334

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[Nextjs] Sample in Docker env references linked packages using lowercase path #1334

merged 1 commit into from
Feb 9, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 9, 2023 •
edited
Loading

Description / Motivation

  • Inside the Docker env, the sample app uses a lowercased path and can't find an appropriate module in case you have capitalized letters in your sample app dist path

Testing Details

Launched docker env with a reference to sample app inside the monorepo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team February 9, 2023 09:29
@addy-pathania addy-pathania merged commit 5bf013a into dev Feb 9, 2023
@addy-pathania addy-pathania deleted the bugfix/572390 branch February 9, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @addy-pathania