Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js][Image] Exclude width/height when fill prop is provided #1336

Merged
merged 3 commits into from
Feb 13, 2023
Merged

[Next.js][Image] Exclude width/height when fill prop is provided #1336

merged 3 commits into from
Feb 13, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 13, 2023 •
edited
Loading

Description / Motivation

Testing Details

Manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team February 13, 2023 12:33
@illiakovalenko illiakovalenko changed the title [Next.js] [Image] Exclude width/height when fill prop is provided [Next.js][Image] Exclude width/height when fill prop is provided Feb 13, 2023
ambrauer
ambrauer approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ambrauer ambrauer merged commit 35b8baa into dev Feb 13, 2023
@ambrauer ambrauer deleted the bugfix/572600 branch February 13, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer