Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-rendering-host] fix react rendering host ESM error #1337

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[sitecore-jss-rendering-host] fix react rendering host ESM error #1337

merged 1 commit into from
Feb 13, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Feb 13, 2023 •
edited
Loading

Downgrade dependency del to 6.1.1 as it migrated to ESM from 7.0.0
HERE

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team February 13, 2023 15:25
illiakovalenko
illiakovalenko approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit 6542983 into dev Feb 13, 2023
@illiakovalenko illiakovalenko deleted the fix/572653-rendering-error branch February 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @illiakovalenko