[nextjs] Add support for fallback point of sale #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
requested changes
Mar 7, 2023
illiakovalenko
requested changes
Mar 7, 2023
| const pointOfSale = site.pointOfSale | ||
| ? site.pointOfSale[language] || site.pointOfSale[site.language] | ||
| : ''; | ||
| const pointOfSale = resolvePointOfSale(site, language); |
There was a problem hiding this comment.
If we have POS resolver, in this case, it needs to be customizable, so can be provided in config
There was a problem hiding this comment.
SiteResolver is more complex than PosResolver needs to be. I believe it's better to keep point of sale resolution simple, but separate, so that it can be easily changed if the point of sale data format changes in future.
But yes, we need to have a way to override resolution in middleware.
ambrauer
reviewed
Mar 7, 2023
ambrauer
suggested changes
Mar 8, 2023
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
Comment on lines
53
to
54
| // you can also pass a custom point of sale resolver into middleware | ||
| // resolvePointOfSale: (site, language) => { ... } |
There was a problem hiding this comment.
I think we should have this wired up to use the PosResolver.resolve here to make it more explicit (and match usage in CdpPageView.tsx). If possible, keep the old comments (maybe even function name?)
Suggested change
| // you can also pass a custom point of sale resolver into middleware | |
| // resolvePointOfSale: (site, language) => { ... } | |
| // This function resolves point of sale for cdp calls. | |
| // Point of sale may differ by locale and middleware will use request language to get the correct value every time it's invoked | |
| getPointOfSale: PosResolver.resolve, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Point of sale values retrieved from Sitecore side can have a fallback entry with a wildcard key. This PR ensures JSS can use it when needed.
Testing Details
Types of changes