Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs] Implemented MiddlewareBase abstraction. Skip Redirects middleware during editing #1370

Merged
merged 4 commits into from
Mar 9, 2023
Merged

[sitecore-jss-nextjs] Implemented MiddlewareBase abstraction. Skip Redirects middleware during editing #1370

merged 4 commits into from
Mar 9, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Mar 8, 2023 •
edited
Loading

Description / Motivation

  • Added debug logging for RedirectsMiddleware
  • RedirectsMiddleware is skipped during editing
  • Introduced MiddlewareBase abstraction that includes common functionality for all the middlewares

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [sitecore-jss-nextjs] Implemented MiddlewareBase abstraction. Skip Redirects middleware during editing. [sitecore-jss-nextjs] Implemented MiddlewareBase abstraction. Skip Redirects middleware during editing Mar 8, 2023
@illiakovalenko illiakovalenko requested a review from a team March 8, 2023 11:45
ambrauer
ambrauer reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, see some thoughts

packages/sitecore-jss-nextjs/src/middleware/middleware.ts Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/multisite-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts Outdated Show resolved Hide resolved
@illiakovalenko illiakovalenko requested a review from ambrauer March 9, 2023 09:50
ambrauer
ambrauer approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Approved with some final recommendations

packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/multisite-middleware.ts Outdated Show resolved Hide resolved
packages/sitecore-jss-nextjs/src/middleware/middleware.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko requested a review from ambrauer March 9, 2023 16:00
ambrauer
ambrauer approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit 0ad294b into dev Mar 9, 2023
@ambrauer ambrauer deleted the bugfix/570878 branch March 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer