Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-rendering-host] Retire devServer #1426

Merged
merged 6 commits into from
Apr 11, 2023
Merged

[sitecore-jss-rendering-host] Retire devServer #1426

merged 6 commits into from
Apr 11, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

devServer is removed from sitecore-jss-rendering-host. renderingHostServer would be the only way to use rendering-host with react apps.
devServer was poorly documented and rarely used which led to the decisions to retire it

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team April 10, 2023 18:11
@art-alexeyenko art-alexeyenko mentioned this pull request Apr 10, 2023
Closed
7 tasks
ambrauer
ambrauer approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a suggestion for the README, otherwise 👍

CHANGELOG.md Outdated Show resolved Hide resolved
illiakovalenko
illiakovalenko approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, see one comment below

packages/sitecore-jss-rendering-host/package.json Outdated Show resolved Hide resolved
art-alexeyenko and others added 3 commits April 11, 2023 14:29
@art-alexeyenko art-alexeyenko merged commit 391e7bb into dev Apr 11, 2023
@art-alexeyenko art-alexeyenko deleted the feature/572680-webpack-updates branch April 11, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @ambrauer @illiakovalenko