Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular] Avoid double requests to dictionary service #1473

Merged
merged 2 commits into from
May 5, 2023
Merged

[angular] Avoid double requests to dictionary service #1473

merged 2 commits into from
May 5, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented May 5, 2023 •
edited
Loading

Description / Motivation

Remove extra calls to translate.use to avoid extra Dictionary service calls

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team May 5, 2023 20:05
addy-pathania
addy-pathania approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@addy-pathania addy-pathania merged commit ff709b5 into dev May 5, 2023
@addy-pathania addy-pathania deleted the bug/572372-angular-remove-extra-la-fallback branch May 5, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @addy-pathania