Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix installed sitecore-jss-* dependency version #1481

Merged
merged 8 commits into from
May 12, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 12, 2023

When trying to scaffold a JSS app with a specific patch version the sitecore-jss-* dependencies jump to the next minor version which is unexpected.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title [Hotfix] Fix installed sitecore-jss-* dependency version [Hotfix] Fix installed sitecore-jss-* dependency version May 12, 2023
@addy-pathania addy-pathania requested a review from a team May 12, 2023 19:24
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix changelog, otherwise 👍

@addy-pathania addy-pathania merged commit 3fc47b1 into release/21.0.0 May 12, 2023
@addy-pathania addy-pathania deleted the hotfix/21.1.3/584823 branch May 12, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants