Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextjs][sxa]Moving saas and sass-alias from devDependencies to dependencies #1489

Merged
merged 1 commit into from
May 19, 2023

Conversation

nsgocev
Copy link
Contributor

@nsgocev nsgocev commented May 17, 2023

Description / Motivation

sass and saas-alias packages are used in the runtime of the Next.JS SXA Starter Kit inside the "saas" plugin.
Some of the hosting providers (like CloudflarePages and Azure Static Web Apps) only install packages listed as dependencies when they post-process the build artifacts which causes the application to never start.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - nothing much to test :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@nsgocev nsgocev marked this pull request as draft May 17, 2023 13:38
@nsgocev nsgocev marked this pull request as ready for review May 17, 2023 13:38
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit bfbc2db into Sitecore:dev May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants