[RAV] Remove persisted query link #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kendoce
reviewed
Jun 6, 2023
packages/create-sitecore-jss/src/templates/angular/src/app/jss-graphql.module.ts
Show resolved
Hide resolved
kendoce
reviewed
Jun 6, 2023
packages/create-sitecore-jss/src/templates/react/src/lib/GraphQLClientFactory.js
Show resolved
Hide resolved
kendoce
reviewed
Jun 6, 2023
packages/create-sitecore-jss/src/templates/vue/src/lib/GraphQLClientFactory.js
Show resolved
Hide resolved
ambrauer
reviewed
Jun 6, 2023
ambrauer
suggested changes
Jun 6, 2023
| @@ -3,10 +3,8 @@ import { HttpClientModule, HttpHeaders } from '@angular/common/http'; | |||
| import { InMemoryCache, NormalizedCacheObject, PossibleTypesMap } from '@apollo/client/core'; | |||
| import { Apollo, ApolloModule } from 'apollo-angular'; | |||
| import { HttpBatchLink } from 'apollo-angular/http'; | |||
| import { createPersistedQueryLink } from 'apollo-angular/persisted-queries'; | |||
There was a problem hiding this comment.
Remove apollo-angular/persisted-queries and sha256 dependencies from package.json?
There was a problem hiding this comment.
Removed sha56 but persisted-queries is a submodule of apollo-angular which is the primary dependency for apollo.
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| import 'cross-fetch/polyfill'; | |||
| import { ApolloClient, InMemoryCache } from '@apollo/client'; | |||
| import { sha256 } from 'js-sha256'; | |||
There was a problem hiding this comment.
Remove @apollo/client/link/persisted-queries and sha256 dependencies from package.json?
There was a problem hiding this comment.
Removed sha56 but persisted-queries is a submodule of apollo/client which is the primary dependency for apollo and same for vue.
| @@ -1,6 +1,5 @@ | |||
| import 'cross-fetch/polyfill'; // Apollo uses `fetch`, which needs a polyfill for node and older browsers. | |||
| import { InMemoryCache, ApolloClient } from '@apollo/client/core'; | |||
| import { sha256 } from 'js-sha256'; | |||
There was a problem hiding this comment.
Remove @apollo/client/link/persisted-queries and sha256 dependencies from package.json?
addy-pathania
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge delivery endpoint doesn't support Automatic Persisted Queries therefore we have a error on the graphql page. To workaround this issue we need to switch our implementation to use the http batch link queries.
Description / Motivation
Testing Details
Types of changes