Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nextjs] Move template related script to the base package #1520

Merged
merged 12 commits into from
Jun 12, 2023
Merged

[Nextjs] Move template related script to the base package #1520

merged 12 commits into from
Jun 12, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jun 12, 2023 •
edited
Loading

Description / Motivation

  • [sitecore-jss-nextjs]:
    • Introduced ComponentBuilder class for generating component factories and module factories.
    • ComponentPropsService componentModule property renamed to moduleFactory.
    • Adjusted ComponentModule definition:
      • renamed to ModuleFactory.
      • Module type besides the initial limited set of props now can also include any React component. React.Component is replaced by React.ComponentType.
  • [sitecore-jss-dev-tools]:
    • Introduced nextjs submodule, which contains component builder generation functionality.
  • [templates/nextjs]:
    • Introduced plugins architecture for component builder and scaffold component generation processes.
    • Reused new utils added to sitecore-jss-dev-tools.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title Commit [Nextjs] Move template related script to the base package Jun 12, 2023
@illiakovalenko illiakovalenko requested a review from a team June 12, 2023 08:18
ambrauer
ambrauer approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've approved, but see some suggestions / questions for consideration.

...itecore-jss/src/templates/nextjs-styleguide/scripts/scaffold-component/plugins/next-steps.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-sxa/src/pages/404.tsx Outdated Show resolved Hide resolved
...es/create-sitecore-jss/src/templates/nextjs/scripts/scaffold-component/plugins/next-steps.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/[[...path]].tsx Show resolved Hide resolved
packages/sitecore-jss-dev-tools/src/templating/nextjs/generate-component-builder.ts Show resolved Hide resolved
packages/sitecore-jss-dev-tools/src/templating/plugins.ts Show resolved Hide resolved
@illiakovalenko illiakovalenko requested a review from ambrauer June 12, 2023 15:15
@ambrauer
Copy link
Contributor

👍

@ambrauer ambrauer merged commit b96bed6 into dev Jun 12, 2023
@ambrauer ambrauer deleted the feature/586202 branch June 12, 2023 15:32
@illiakovalenko illiakovalenko mentioned this pull request Jun 26, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer Awaiting requested review from ambrauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer