Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#544756: [templates/nextjs-sxa] added cdn for font-awesome font #1536

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Jun 23, 2023

Description / Motivation

There was problem with CORS and getting fonts
Added CDN for FontAwesome fonts

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi changed the title #544756: added cdn for font-awesome font #544756: [templates/nextjs-sxa] added cdn for font-awesome font Jun 23, 2023
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/544756-fix-font-awesome branch from fcc21bf to eef66e6 Compare June 27, 2023 13:07
@illiakovalenko
Copy link
Contributor

@matkovskyi Please, merge conflicts

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/544756-fix-font-awesome branch from eef66e6 to 883acdc Compare June 27, 2023 15:08
@sc-ruslanmatkovskyi sc-ruslanmatkovskyi force-pushed the bugfix/544756-fix-font-awesome branch from 883acdc to 611bf05 Compare June 27, 2023 15:12
@illiakovalenko illiakovalenko merged commit 270a5dc into dev Jun 27, 2023
@illiakovalenko illiakovalenko deleted the bugfix/544756-fix-font-awesome branch June 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants