#544756: [templates/nextjs-sxa]fix font awesome #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ruslanmatkovskyi
force-pushed
the
bugfix/544756-fix-font-awesome
branch
from
df71209 to
f619575
Compare
illiakovalenko
approved these changes
Jun 30, 2023
CHANGELOG.md
Outdated
| @@ -17,10 +17,10 @@ Our versioning strategy is as follows: | |||
|
|
|||
| ### 🐛 Bug Fixes | |||
|
|
|||
| * `[sitecore-jss-nextjs]` Referrer is not captured by Personalize middleware ([#1542](https://github.com/Sitecore/jss/pull/1542)) | |||
| * `[templates/nextjs-sxa]` Fix font awesome - added CDN instead of using node_modules(problem with CORS) ([#1536](https://github.com/Sitecore/jss/pull/1536)) | |||
There was a problem hiding this comment.
This PR should be added as a second one here, it's related
sc-ruslanmatkovskyi
force-pushed
the
bugfix/544756-fix-font-awesome
branch
from
f619575 to
1474154
Compare
illiakovalenko
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Reverted @FontAwesome package for mixins
Testing Details
Types of changes