Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-react-forms] Disable form while submit is in progress #1611

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[sitecore-jss-react-forms] Disable form while submit is in progress #1611

merged 2 commits into from
Sep 14, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Sep 13, 2023 •
edited
Loading

Description / Motivation

Ensures form is disabled until submit is complete to avoid problems.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team September 13, 2023 22:08
addy-pathania
addy-pathania approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work around. 👍🏼

Please update the changelog.

@art-alexeyenko art-alexeyenko merged commit f8d5f67 into dev Sep 14, 2023
@art-alexeyenko art-alexeyenko deleted the bug/jss-591-submit-form-not-disabled branch September 14, 2023 17:27
art-alexeyenko added a commit that referenced this pull request Sep 18, 2023
@art-alexeyenko
Disable form while submit is in progress (#1611)
ab42cf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @addy-pathania