Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting and react types errors for monorepo #1613

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Sep 18, 2023

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team September 19, 2023 13:11
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you really helped us out.

I'd maybe also extend the changelog entry a little by specifying react version change and mentioning the type problem that was fixed by it. But the final call on it is yours.

@addy-pathania addy-pathania changed the title Fix linting error for monorepo Fix linting and react types errors for monorepo Sep 19, 2023
@art-alexeyenko art-alexeyenko merged commit 8a4072f into dev Sep 19, 2023
1 check passed
@art-alexeyenko art-alexeyenko deleted the bugfix/jss-687-lint-fail branch September 19, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants