Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular/xmcloud] Fix angular app initialization setup for xmc #1866

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[angular/xmcloud] Fix angular app initialization setup for xmc #1866

merged 1 commit into from
Jul 30, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jul 30, 2024 •
edited
Loading

Description / Motivation

  • Follow up to jss-3563 - Angular Initializer support
    • Add transform logic to the add-on

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team July 30, 2024 17:19
@addy-pathania addy-pathania changed the title [angular/xmcloud] Add transform logic to angular xm-cloud add-on [angular/xmcloud] Fix Angular Initialization setup for xmc Jul 30, 2024
@addy-pathania addy-pathania changed the title [angular/xmcloud] Fix Angular Initialization setup for xmc [angular/xmcloud] Fix angular app initialization setup for xmc Jul 30, 2024
@addy-pathania addy-pathania merged commit 84bf471 into feature/angular-xmc-proxy Jul 30, 2024
2 checks passed
@addy-pathania addy-pathania deleted the bugfix/jss-3724 branch July 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko Awaiting requested review from art-alexeyenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @art-alexeyenko @apathania22