Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular-xmcloud] Introduce Angular SXA Container component #1872

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Aug 1, 2024

Description / Motivation

Introduces the SXA Container component for Angular.

Also includes:

  • an abstract base class SxaComponent which can be shared among (incoming) SXA components
  • adjustment to aggregated SXA 'styles' param which works for all SXA components (not all components have rendering.params.FieldNames defined e.g. Container)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) Running local Angular app connected to XMC instance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team August 1, 2024 22:18
@ambrauer ambrauer force-pushed the feature/JSS-3692-sxa-container-component branch from f8f6245 to dbf8ad3 Compare August 5, 2024 20:34
@ambrauer ambrauer requested a review from illiakovalenko August 6, 2024 13:17
@ambrauer ambrauer merged commit af7c4bd into dev Aug 6, 2024
1 check passed
@ambrauer ambrauer deleted the feature/JSS-3692-sxa-container-component branch August 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants