[sitecore-jss-nextjs] the algorithm of redirects middleware has been fixed #SXA-7405 #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ruslanmatkovskyi
changed the title
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7405-redirects
branch
from
bc0e1a4 to
ca412ed
Compare
illiakovalenko
requested changes
Aug 9, 2024
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7405-redirects
branch
from
c5b6e16 to
2209439
Compare
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7405-redirects
branch
from
2209439 to
004a09d
Compare
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.test.ts
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.test.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
Aug 13, 2024
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7405-redirects
branch
2 times, most recently
from
4688289 to
7fddcde
Compare
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7405-redirects
branch
from
7fddcde to
a1de7b2
Compare
illiakovalenko
pushed a commit
that referenced
this pull request
Aug 13, 2024
… fixed #SXA-7405 (#1876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
When a user clicks on a link generated by the Link component from next/link, Next.js adds special parameters in the route called path. This is why the redirects middleware doesn't work correctly when the user clicks on the link. In this PR, a special method is added to remove this parameter from Next.js
Testing Details
Types of changes