Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-sitecore-jss] Only put FETCH_WITH for SXP template, pass proxyPath to prompt #1884

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[create-sitecore-jss] Only put FETCH_WITH for SXP template, pass proxyPath to prompt #1884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82672ea
only put FETCH_WITH for SXP template
art-alexeyenko Aug 12, 2024
96abc36
consider pre-populated proxyAppDestination in prompt
art-alexeyenko Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/create-sitecore-jss/src/initializers/angular-xmcloud/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default class AngularXmCloudInitializer implements Initializer {
yes: args.yes,
destination: args.destination,
proxyName: 'node-xmcloud-proxy',
proxyAppDestination: args.proxyAppDestination,
};
const proxyDetails = await inquirer.prompt<ProxyArgs>(proxyPrompts, promptArgs);
args.proxyAppDestination = proxyDetails.proxyAppDestination;
Expand Down
2 changes: 2 additions & 0 deletions packages/create-sitecore-jss/src/templates/angular-sxp/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# The way in which layout and dictionary data is fetched from Sitecore
FETCH_WITH=<%- fetchWith %>
art-alexeyenko marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 0 additions & 5 deletions packages/create-sitecore-jss/src/templates/angular/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ GRAPH_QL_ENDPOINT=
# Uses your `package.json` config `appName` if empty.
SITECORE_SITE_NAME=

<% if (!locals.xmcloud) { -%>
# The way in which layout and dictionary data is fetched from Sitecore
FETCH_WITH=<%- fetchWith %>
<% } -%>

# Your default app language.
DEFAULT_LANGUAGE=

Expand Down