Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular-xmcloud] Introduce angular SXA Image and Banner components #1886

Merged
merged 14 commits into from
Aug 19, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Aug 13, 2024

Description / Motivation

Introduce SXA Image and Banner components

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team August 13, 2024 09:55
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see one comment. Otherwise looks good.

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@illiakovalenko illiakovalenko force-pushed the dev branch 2 times, most recently from 99c9982 to e104237 Compare August 19, 2024 07:19
@yavorsk yavorsk merged commit bc24775 into dev Aug 19, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-3693 branch August 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants