Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-sitecore-jss] Better wording around multiple apps installed #1888

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[create-sitecore-jss] Better wording around multiple apps installed #1888

merged 1 commit into from
Aug 14, 2024

Conversation

art-alexeyenko
Copy link
Contributor

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from kendoce August 14, 2024 00:30
illiakovalenko
illiakovalenko approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit 0777253 into dev Aug 14, 2024
2 checks passed
@illiakovalenko illiakovalenko deleted the bug/better-jss-create-success-msg branch August 14, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@kendoce kendoce Awaiting requested review from kendoce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko