Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-nextjs] Link component prefetches files #1956

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[sitecore-jss-nextjs] Link component prefetches files #1956

merged 3 commits into from
Oct 23, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 21, 2024 •
edited
Loading

Description / Motivation

We need to render regular React link instead of Next.js link component when relative URL has a file extension

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team October 21, 2024 16:46
yavorsk
yavorsk approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yavorsk yavorsk merged commit fd2c15d into dev Oct 23, 2024
1 check passed
@yavorsk yavorsk deleted the bugfix/JSS-3398 branch October 23, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @yavorsk