Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular-xmcloud][xmcloud-proxy] Move PERSONALIZE_SCOPE to angular SPA #1973

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Nov 14, 2024

Description / Motivation

This ensures PERSONALIZE_SCOPE is not duplicated between proxy and angular app.
Potentially to change in future - but so far the variable is used in both personalize and CDP page views - so the base SPA app is where it currently should be.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team November 14, 2024 22:27
@addy-pathania
Copy link
Contributor

As discussed, we should move all the personalize related env variables from proxy to SPA.

@art-alexeyenko
Copy link
Contributor Author

art-alexeyenko commented Nov 15, 2024

@addy-pathania I'm not sure it is a good idea for timeout variables. Having to rebuild angular app when switching timeouts back and forth (during load test, for example?) would be a pain. And unlike the scope, timeouts are only used on server side.
@illiakovalenko what do you think?

@illiakovalenko
Copy link
Contributor

@art-alexeyenko @addy-pathania I think that, potentially, we can leave "timeout" variables under the "proxy" since it's fully belongs to the middleware and proxy configuration. Like we did for "JSS_EDITING_SECRET"

@addy-pathania addy-pathania merged commit da1ead1 into dev Nov 18, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3529-align-pers-scope branch November 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants