Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and fix ts errors #266

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

sc-illiakovalenko
Copy link
Contributor

  1. Added babel-core dependency, cause vue-jest have peerDependency babel-core
    https://github.com/Sitecore/jss/compare/feature/356384?expand=1#diff-2be57abd432f87f7aafe80e047aea9a9R30
  2. Fixed typescript errors
  3. In snapshots was added background style, by jest, i think before update was a bug, that background style wasn't added (because we have this style in our component)
    https://github.com/Sitecore/jss/compare/feature/356384?expand=1#diff-893ef5b8f65badc50ec0d301e4f6184eR4
  4. Ran e2e - everything is passed, manually opened vue sample app - and everything is working

Copy link
Collaborator

@sc-dawidrutkowski sc-dawidrutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@sc-illiakovalenko sc-illiakovalenko merged commit 355bb07 into dev Sep 27, 2019
@sc-illiakovalenko sc-illiakovalenko deleted the feature/356384 branch September 27, 2019 13:15
sc-dawidrutkowski added a commit that referenced this pull request Dec 3, 2019
* Added support for TypeScript when 'jss build'ing

* Type-hint field value.

* Update dataModels.ts

* Move type hint to Field.

* Type-lock return value when defaultValue provided.

* Fix to copy host style attribute to its children dynamic components

* changed spacing

* updates for ssr

* Add loader for lazy loaded components

* Add some documentation

* Placeholder loading component

* Use ng-template instead of ng-content

* Fix typo

* Export SitecoreContextReactContext

See #224

* WIP: simple http listener that accepts JSS view engine args, performs SSR, and returns result to caller.

* Moved JSS rendering host to separate package.

* SUGCON demo prep

* Removed unnecessary console.log statements from htmlTemplateFactory.js

* Changed `start:http-renderer` script name to `start:rendering-host`

* Demo content for content block component.

* Changed `sc_renderengineurl` querystring key to the CORRECT `sc_httprenderengineurl`. doh, smh.

* Incorporating `defaultAppInvocationInfoResolver` into the renderingHostServer startup script.

* removed static `jss` subdomain for ngrok tunnel

* Fixing tests

* #61 Nested component definitions via Item Link returns only IDs

* Upgrade dependencies with critical and high security issues (#252)

Upgrade dependencies

* Upgrade cypress

* downgrade dependency version

* Feature/356383 (#256)

Upgrade sitecore-jss-react package dependencies

* remove InferProps (#259)

remove InferProps

* Feature/356379 (#265)

* update react sample dependencies

* update dependencies and fix ts errors (#266)

Upgrade Vue package dependencies

* #267 Error in description of one of methods of Manifest interface

* Upgrade Vue sample (#269)

Upgrade Vue sample

* Feature/356380: Update Angular

* Upgrade jss-angular and jss-angular-schematics and jss-sample-app

* Feature/356378 (#272) Upgrade CLI Packages

Upgrade CLI Packages

* Use Object.entries instead of Object.keys (#274)

Use Object.entries instead of Object.keys

* mediaApi.updateImageUrl loses revision querystring (#275)

mediaApi.updateImageUrl loses revision querystring

* DevTools loading hidden files and crashing (#276)

* Feature/356373 (#273) Node Proxy: CURL URL -IL returns 500 OK

Node Proxy: CURL URL -IL returns 500 OK

* change logo (#279)

change logo

* upgrade react-native sample (#282)

upgrade react-native sample

* [React-Native] Extend Image component to render svg images (#283)

* add react-native-svg to sample app

* update react-native package-lock

* add react-native-svg to sitecore-jss-react-native

* #348713Explicitly state that field names are not affected by the serialization configuration on Layout Service (#284)

* #348713 Explicitly state that field names are not affected by the serialization configuration on Layout Service

* #348713 Update

* Extended a CD server setup instructions (#286)

* React native sample app (#291)

React native sample app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants