Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly evaluates the value of SITECORE_ENABLE_DEBUG #302

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

pedrolamas
Copy link
Contributor

Description

At the moment, setting the SITECORE_ENABLE_DEBUG environment variable to anything will enable debug, even if we set it to "false".

This ensures that we only enable debug if SITECORE_ENABLE_DEBUG is set to "true" (independently of case)

Motivation

Ensures that users can set SITECORE_ENABLE_DEBUG to "false" to disable SSR debug.

How Has This Been Tested?

In our local implementation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.

Copy link

@VaticanUK VaticanUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a sensible change

@sc-antonkulagin sc-antonkulagin merged commit 37562d6 into Sitecore:dev Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants