[NextJS] Move LayoutService to sitecore-jss package #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
suggested changes
Dec 14, 2020
ambrauer
suggested changes
Dec 15, 2020
ambrauer
suggested changes
Dec 16, 2020
| import { HttpJsonFetcher } from './httpClientInterface'; | ||
| import { IncomingMessage, ServerResponse } from 'http'; | ||
|
|
||
| export type DataFetcherResolver = (req?: IncomingMessage, res?: ServerResponse) => HttpJsonFetcher<LayoutServiceData>; | ||
| export type DataFetcherResolver<T> = (req?: IncomingMessage, res?: ServerResponse) => HttpJsonFetcher<T>; |
There was a problem hiding this comment.
Think we could make an exception and use any here to avoid having 2 DataFetcherResolvers on the LayoutServiceInstanceConfig.
Suggested change
| export type DataFetcherResolver<T> = (req?: IncomingMessage, res?: ServerResponse) => HttpJsonFetcher<T>; | |
| export type DataFetcherResolver = (req?: IncomingMessage, res?: ServerResponse) => HttpJsonFetcher<any>; |
ambrauer
reviewed
Dec 16, 2020
| fetchPlaceholderData( | ||
| placeholderName: string, | ||
| itemPath: string, | ||
| req?: IncomingMessage, |
There was a problem hiding this comment.
We should add language?: string, as 3rd parameter and pass it to getFetchOptions().
There was a problem hiding this comment.
Good call, will add
ambrauer
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
How Has This Been Tested?
Types of changes
/docsdirectory)Checklist: