Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nextjs][Regression] jss start for newly created app fail #795

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[Nextjs][Regression] jss start for newly created app fail #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ages/sitecore-jss-dev-tools/src/disconnected-server/create-default-disconnected-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export interface DisconnectedServerOptions {
/**
* Module to require before starting the disconnected server (i.e. a transpiler, or a config script that loads one)
*/
requireArg?: string;
requireArg?: string | null;

/**
* Express-like server instance to attach to. Defaults to a new Express instance if not passed.
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-dev-tools/src/manifest-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface ManifestManagerOptions {
rootPath?: string;
sourceFiles?: string[];
watchOnlySourceFiles?: string[];
requireArg?: string;
requireArg?: string | null;
outputPath?: string;
pipelinePatchFiles?: string[];
appName?: string;
Expand Down
2 changes: 1 addition & 1 deletion samples/nextjs/scripts/disconnected-mode-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const serverOptions = {
appRoot: path.join(__dirname, '..'),
appName: config.appName,
// Prevent require of ./sitecore/definitions/config.js, because ts-node is running
requireArg: '',
requireArg: null,
watchPaths: ['./data'],
language: config.language,
port: Number(process.env.PROXY_PORT) || 3042,
Expand Down