Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Use the app name as the prefix value for templates #811

Merged
merged 25 commits into from
Sep 13, 2021

Conversation

CobyPear
Copy link
Contributor

Continuation of work started in #800 and #810 - apply prefix and new templateName property to components in definition files and graphql queries for React. Also adds --prefix true|false flag to jss create (default false)

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

* update graphql fragment types
@CobyPear CobyPear requested a review from a team September 10, 2021 22:13
@vercel
Copy link

vercel bot commented Sep 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/44TdkmGZiMjHxmb8surEURy5CxfH
✅ Preview: Failed

@ambrauer ambrauer merged commit 65669a6 into dev Sep 13, 2021
@ambrauer ambrauer deleted the feature/482700-prefix-react branch September 13, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants