-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Angular] Use the app name as prefix value for templates #813
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/F5zNhzGT2hzPpqeU3hDjFHSCW4hd [Deployment for 566766b failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few formatting things, and the samples/vue/package-lock.json
can be removed from this PR as well (it's a known issue that is to be investigated soon). Looks good otherwise!
When developing locally, multiple templates with the same name will conflict causing errors when using strongly typed GraphQL queries.
This feature adds a prefix to some files so that when jss create is run, the prefix is replaced with the appname, which will give each template a unique name in Sitecore when using jss deploy.
Description / Motivation
Added a prefix to pertinent files and filenames in the Angular sample app
Testing Details
Used jss create to scaffold a new Angular app and deployed it to Sitecore along with the sample app - no conflicting template names = no errors!
Types of changes
/docs
directory)