[Focused Improvement] Consolidate packages

[addy-pathania]

Consolidate manifest and pipeline packages into dev-tools

Description / Motivation

To be able to maintain all the packages in a easier way in future.

--> Changes made

• Package name = Sitecore.jss : Organized files into sub-modules
  - graphql = no change
  - i18 = no change
  - layout = no change
  - media = new
  - testData = no change
  - tracking
  before: separate individual package
  now: submodule in base package
  - utils = moved all loosely left related files to this submodule.

• Package name = Sitecore-jss-angular : Changed package.json

• Package name = Sitecore-jss-angular-schematics : No change

• Package name = Sitecore-jss-cli : No change

• Package name = Sitecore-jss-dev-tools : Moved manifest, pipelines and update package into this package

  • Manifest
    • changes to import statements within the package.
      before: separate individual package
      now: part of this package
  • Pipelines
    • changes to import statements within the package.
      before: separate individual package
      now: part of this package
  • Update
    • changes to import statements within the package.
      before: separate individual package
      now: part of this package

• Package name = Sitecore-jss-forms : No change

• Package name = Sitecore-jss-nextjs :

  • Changed package.json
  • Now importing from sub-modules from base package(sitecore-jss) instead of directly from base-package
  • changes to import statements within the package.

• Package name = Sitecore-jss-proxy : No change

• Package name = Sitecore-jss-react :

  • Changed package.json
  • Now importing from sub-modules from base package(sitecore-jss) instead of directly from base-package
  • changes to import statements within the package.

• Package name = Sitecore-jss-react-forms : No change

• Package name = Sitecore-jss-native : No Change

• Package name = Sitecore-jss-hosts : No change

• Package name = Sitecore-jss-vue :

  • Changed package.json
  • Now importing from sub-modules from base package(sitecore-jss) instead of directly from base-package
  • changed all imports coming from manifest, pipelines, update package now point to the sitecore-jss-dev-tools package.

--> Sample Apps

• changed package.json
• changed all imports coming from manifest, pipelines, update package now point to the sitecore-jss-dev-tools package.

Testing Details

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update (non-breaking change; modified files are limited to the /docs directory)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/GBXoHizdFgjhqeRPwutqL2Lt6Vby
✅ Preview: Failed

[Deployment for 8129389 failed]

[illiakovalenko]

Well done!

• I would propose you to introduce path aliases using tsconfig
  Currently, we reference one package from another, and in sitecore-jss-dev-tools you can see that you added a lot of long paths like ../../../../index etc.
  https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping
  https://dev.to/larswaechter/path-aliases-with-typescript-in-nodejs-4353
• For customer it has breaking changes, they still will use separate packages in the sample. It should be documented in release notes as a breaking change
• I think we need to move typings - packages/sitecore-jss-dev-tools/src/manifest/typings.d.ts under src folder, so it should be at the root of the package.

[ambrauer]

See specific comments. Overall looks great!

[ambrauer]

Approved 👍👍