Make tmpDir a configurable parameter #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this simple change, we can run this code on Azure Functions on a consumption plan. The os.tmpdir couldn't be set using an environment variable. If this change is accepted I don't need to copy this whole file over In our codebase just for changing the tmpDir location.
|
@erwinsmit is attempting to deploy a commit to the Sitecore JSS Team on Vercel. A member of the Team first needs to authorize it. |
ambrauer
suggested changes
Oct 28, 2021
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
Thanks, I've accepted the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I'm loving the Next.js JSS SDK so far, we are currently running it on a custom server hosted in Azure Functions. With a custom server, the API pages don't work so I had to create separate Azure Functions for these, this was fine because middlewares (EditingRenderMiddleware/EditingDataMiddleware) are easily imported and configurable. In our case, this was useful because the default dataDiskCache middleware did not work correctly.
With this simple change, we can use the default dataDiskCache middleware. Because the only issue with the implementation is that the os.tmpdir does not seem to work using Azure Functions on a consumption plan.