[NextJS] Add .gitattributes to Next.js sample app with CRLF line endings #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/FwzbDV7TvZDc6xkVK7ET28JPvZsw [Deployment for b3fab11 failed] |
illiakovalenko
changed the title
ambrauer
approved these changes
Nov 15, 2021
|
@illiakovalenko Could you clarify what's the reason using CRLF in the first place? |
|
@thezaff the problem here was that Next.js app couldn't build in Vercel due to Prettier errors (Vercel must have changed their build agent OS, when I added this change). And in general it follows our basic rules in all the samples and monorepo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
The OOTB Next.js sample fails to build on Vercel due to Prettier errors (note this previously worked - Vercel must have changed their build agent OS).
Testing Details
Types of changes