[Typescript] Bug fix to allow custom components #875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for custom components in field-factory.tsx I am trying to add a custom react component to the jss-react-forms and relying on typescript.
The method definition only allows of type FieldTypes Enum and I dont have an override to pass my custom component implementation. Interally its a map that takes string and react component for that type.
I have added string so it can be FieldTypes for OOB field and custom field can be added with the {guid} string.
|
@bala-one is attempting to deploy a commit to the Sitecore JSS Team on Vercel. A member of the Team first needs to authorize it. |
|
@CobyPear The new pull request with proper branch. |
|
Our CI shows a linting error, can you run |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Support for custom components in field-factory.tsx I am trying to add a custom react component to the jss-react-forms and relying on typescript.
The method definition only allows of type FieldTypes Enum and I dont have an override to pass my custom component implementation. Internally its a map that takes string and react component for that type.
I have added string so it can be FieldTypes for OOB field and custom field can be added with the {guid} string.
Testing Details
Sitecore 10.1 JSS SXA Docker environment Typescript
In my local instance I am using this approach and it works.
Types of changes