[Next.js] Component props auto-injection by Placeholder #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/5pYsodEMRm7qhNo5XTNSFP3Y2fWR [Deployment for 44ef0f9 failed] |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Currently, after implementing getStaticProps or getServerSideProps using our component-level data fetching, you need to use useComponentProps to get at the retrieved values. Your component props then also need to include the rendering so that you can get at the rendering uid which is needed when calling this hook. Implementing Storybook stories for such components requires that you mock the full component props context, further complicating use.
We should take advantage of the fact that we own this component's creation, and retrieve/merge the props within the placeholder logic. This may require refactoring the React placeholder to allow Next.js to add this logic/props to the component creation.
Testing Details
Types of changes