Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAV] Fix peer dependency errors #910

Merged
merged 3 commits into from
Jan 19, 2022
Merged

[RAV] Fix peer dependency errors #910

merged 3 commits into from
Jan 19, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 19, 2022 •
edited
Loading

Description / Motivation

  • @ngx-meta/core doesn't support Angular 11, a new meta service was implemented
  • eslint for Vue now is compatible with vue-eslint-plugin
  • Fixes for React will be added in Apollo Client Upgrade PR
  • Removed not needed peer dep chalk for sitecore-jss-dev-tools

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Jan 19, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/67MHtzpYvmXUaD6HhmJJ3kcLNv7v
✅ Preview: Failed

[Deployment for 9969039 failed]

@illiakovalenko illiakovalenko requested a review from a team January 19, 2022 11:09
ambrauer
ambrauer suggested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one question re: eslint.

packages/create-sitecore-jss/src/templates/vue/package.json Show resolved Hide resolved
@illiakovalenko illiakovalenko merged commit cd54126 into dev Jan 19, 2022
@illiakovalenko illiakovalenko deleted the feature/512988 branch January 19, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer