Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node-headless-ssr-experience-edge/ proxy] Fix for error while running npm start on headless apps #916

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jan 31, 2022

As the base packages were refactored and the @sitecore-jss base package was broken down into submodules, the submodules import was not refactored in the node-headless-ssr-experience-edge and node-headless-ssr-proxy apps.

npm start works as expected after updating imports.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/5oVicv2eAJMpFeSyVrissKHMqgt5
✅ Preview: Failed

@addy-pathania addy-pathania requested a review from a team January 31, 2022 19:21
@addy-pathania addy-pathania changed the title [Bugfix] Error running npm start on headless apps [Node-headless-ssr-experience-edge/ proxy] Fix for error while running npm start on headless apps Jan 31, 2022
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ambrauer ambrauer merged commit 760d9cd into dev Jan 31, 2022
@ambrauer ambrauer deleted the bugfix/517306-error-headless-proxy branch January 31, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants