Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight error message for fetchWith=GraphQL #930

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Feb 8, 2022

Highlighted the error message thrown when user starts the app in disconnected mode but fetchWith=GaphQL.
This would create a better user experience for the user.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team February 8, 2022 21:21
@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/GgTxmq3TcTADgcFJiK7hgJ2RHYmo
✅ Preview: Failed

[Deployment for 5457c0a failed]

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit cf7a13b into dev Feb 9, 2022
@ambrauer ambrauer deleted the feature/514933-error-fetch-with-graphql branch February 9, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants