Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VUE] Experience Editor controls does not work until hard reload is done #950

Merged
merged 2 commits into from
Mar 16, 2022
Merged

[VUE] Experience Editor controls does not work until hard reload is done #950

merged 2 commits into from
Mar 16, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Mar 16, 2022 •
edited
Loading

Description / Motivation

  • We have to reset EE chromes since sometimes experience editor script is executed earlier
    than Vue script and EE can't set required attributes and chromes aren't visible

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Mar 16, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/DcvnQFfJyGEe6BmiNEo6rxV8JEe1
✅ Preview: Failed

[Deployment for 807eb9c failed]

@illiakovalenko illiakovalenko requested a review from a team March 16, 2022 10:52
ambrauer
ambrauer approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit b9d1bb9 into release/20.0.0 Mar 16, 2022
@ambrauer ambrauer deleted the bugfix/521664-20.0.0 branch March 16, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer