Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-headless-ssr-proxy] [node-headless-ssr-experience-edge] Provide ability to use .env #977

Conversation

sc-nikolaoslazaridis
Copy link
Contributor

Description / Motivation

  1. Created a .env file with all variables we pull from process.env.
  2. Added dotenv package
  3. Call the dotenv config in the index.js

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…n the config.js file (with empty values). Added the dotenv package to load the variables from the .env file.
…plate. Added the require(dotenv).config() to the app entry points (index.js).
…with empty values). Added the dotenv package to load the variables from the .env file. Calling the dotenv config() in the index.js.
@sc-nikolaoslazaridis sc-nikolaoslazaridis requested a review from a team April 12, 2022 08:58
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@illiakovalenko illiakovalenko merged commit 5817231 into Sitecore:dev Apr 12, 2022
@ambrauer
Copy link
Contributor

ambrauer commented Apr 12, 2022

@sc-nikolaoslazaridis sc-nikolaoslazaridis deleted the feature/475927-Provide-ability-to-use-.env branch May 9, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants